Taragolis commented on code in PR #37861:
URL: https://github.com/apache/airflow/pull/37861#discussion_r1510218393
##########
airflow/providers/amazon/aws/transfers/redshift_to_s3.py:
##########
@@ -109,27 +109,32 @@ def __init__(
) -> None:
super().__init__(**kwargs)
self.s3_bucket = s3_bucket
- self.s3_key = f"{s3_key}/{table}_" if (table and table_as_file_name)
else s3_key
+ if table and table_as_file_name:
+ s3_key = f"{s3_key}/{table}_"
Review Comment:
I guess the problem here that change allow to pass pre-commit, but still
might complain / doesn't work well with `MapXComArg` / `ZipXComArg`
##########
airflow/providers/amazon/aws/transfers/redshift_to_s3.py:
##########
@@ -109,27 +109,32 @@ def __init__(
) -> None:
super().__init__(**kwargs)
self.s3_bucket = s3_bucket
- self.s3_key = f"{s3_key}/{table}_" if (table and table_as_file_name)
else s3_key
+ if table and table_as_file_name:
+ s3_key = f"{s3_key}/{table}_"
+ else:
+ pass
+ self.s3_key = s3_key
self.schema = schema
self.table = table
self.redshift_conn_id = redshift_conn_id
self.aws_conn_id = aws_conn_id
self.verify = verify
- self.unload_options: list = unload_options or []
+ self.unload_options = unload_options or []
self.autocommit = autocommit
self.include_header = include_header
self.parameters = parameters
self.table_as_file_name = table_as_file_name
self.redshift_data_api_kwargs = redshift_data_api_kwargs or {}
if select_query:
- self.select_query = select_query
+ pass
Review Comment:
🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
