Taragolis commented on code in PR #37861:
URL: https://github.com/apache/airflow/pull/37861#discussion_r1510262938
##########
airflow/providers/amazon/aws/transfers/redshift_to_s3.py:
##########
@@ -109,27 +109,32 @@ def __init__(
) -> None:
super().__init__(**kwargs)
self.s3_bucket = s3_bucket
- self.s3_key = f"{s3_key}/{table}_" if (table and table_as_file_name)
else s3_key
+ if table and table_as_file_name:
+ s3_key = f"{s3_key}/{table}_"
Review Comment:
And I would recommend starts with tests because there is at least two times
when we breaks something that works before during this kind of task
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
