ferruzzi commented on code in PR #37948:
URL: https://github.com/apache/airflow/pull/37948#discussion_r1516763226


##########
airflow/config_templates/config.yml:
##########
@@ -1130,6 +1130,56 @@ metrics:
       type: string
       example: ~
       default: "False"
+traces:
+  description: |
+    Distributed traces integration settings.
+  options:
+    otel_on:
+      description: |
+        Enables sending traces to OpenTelemetry.
+      version_added: 2.9.0
+      type: string
+      example: ~
+      default: "False"
+    otel_host:
+      description: |
+        Specifies the hostname or IP address of the OpenTelemetry Collector to 
which Airflow sends
+        traces.

Review Comment:
   Perhaps a new root-level `otel_integration_on` should control all otel 
features and each component can be overridden with its specific switch?
   
   ```
   AIRFLOW__CORE__OTEL_INTEGRATION_ON = True
   AIRFLOW__METRICS__OTEL_ON = False
   ```
   
   would turn all otel features on, then turn off otel metrics (leaving traces, 
and whatever comes in the future on).  I guess that can come later if at all.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to