dmedora commented on code in PR #37949:
URL: https://github.com/apache/airflow/pull/37949#discussion_r1520226691
##########
airflow/providers/google/cloud/sensors/gcs.py:
##########
@@ -126,6 +130,9 @@ def execute(self, context: Context) -> None:
),
method_name="execute_complete",
)
+ else:
+ if self._exists:
+ return "success"
Review Comment:
Thanks for taking a look, I've updated the PR description (didn't realize
this would get look at while in draft). Today, if an object already exists when
the DAG is first run, the xcom value is not set. "success" is what's returned
today by the deferred mode trigger -
https://github.com/apache/airflow/blob/main/airflow/providers/google/cloud/triggers/gcs.py#L111.
The goal of this fix is essentially the same as what was done for
GCSObjectsWithPrefixExistenceSensor in #37634.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
