bbovenzi commented on code in PR #38021:
URL: https://github.com/apache/airflow/pull/38021#discussion_r1521734303


##########
airflow/www/static/js/dag/details/taskInstance/Logs/LogBlock.tsx:
##########
@@ -59,10 +67,43 @@ const LogBlock = ({ parsedLogs, wrap, tryNumber }: Props) 
=> {
     }
   };
 
+  const onClick = (e: React.MouseEvent<HTMLElement>) => {
+    const target = e.target as HTMLElement;
+    if (target.id?.endsWith("_unfold")) {
+      const gId = target.id.substring(0, target.id.length - 7);

Review Comment:
   I'm not the biggest fan of just hard-coding the number `7`. Perhaps we could 
make `const unfoldString = `_unfold` and we can use `unfoldString.length`. Same 
for fold



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to