eladkal commented on code in PR #38071:
URL: https://github.com/apache/airflow/pull/38071#discussion_r1528722418
##########
airflow/providers/google/cloud/log/stackdriver_task_handler.py:
##########
@@ -99,7 +99,7 @@ def __init__(
super().__init__()
self.gcp_key_path: str | None = gcp_key_path
self.scopes: Collection[str] | None = scopes
- self.name: str = name
+ self.gcp_log_name: str = name
Review Comment:
I don't think this qualify as breaking change. This is a bug fix. Sometimes
bug fixes change behavior when the previous behavior was clearly wrong and
undesired.
Can you think of a senario why someone would want the current behavior over
the fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
