AlexisBRENON commented on code in PR #38071:
URL: https://github.com/apache/airflow/pull/38071#discussion_r1529196456
##########
airflow/providers/google/cloud/log/stackdriver_task_handler.py:
##########
@@ -99,7 +99,7 @@ def __init__(
super().__init__()
self.gcp_key_path: str | None = gcp_key_path
self.scopes: Collection[str] | None = scopes
- self.name: str = name
+ self.gcp_log_name: str = name
Review Comment:
I don't see any "good" use case where someone would want the current
behavior instead of the fix.
@shahar1 I don't change the constructor arguments (you can still get an
instance using `StackdriverTaskHandler(name="foo", ...)`) but I change the
meaning of the instance attribute `name` (up to now it was supposed to be the
name of the GCP log, after this fix it will be the name of the Python handler).
I may add some logs on access (read or write) to the `name` attribute, but I
think it may be hard to implement cleanly and will be too verbose (as it is a
genuine behavior of the `dictConfig` method).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
