dstandish commented on code in PR #37293:
URL: https://github.com/apache/airflow/pull/37293#discussion_r1529745181
##########
airflow/providers/http/hooks/http.py:
##########
@@ -385,8 +387,9 @@ async def run(
for attempt in range(1, 1 + self.retry_limit):
response = await request_func(
url,
- json=data if self.method in ("POST", "PUT", "PATCH") else
None,
params=data if self.method == "GET" else None,
Review Comment:
maybe this should be changed too? this seems fishy also.
maybe this is too much change for folks but .... it doesn't seem like a good
API to shuffle things around like this. i.e. send `data` to params or data or
json depending on this logic. it would seem that it would be better to just
forward everyting blindly. @uranusjr @jedcunningham any thoughts?
##########
airflow/providers/http/hooks/http.py:
##########
@@ -385,8 +387,9 @@ async def run(
for attempt in range(1, 1 + self.retry_limit):
response = await request_func(
url,
- json=data if self.method in ("POST", "PUT", "PATCH") else
None,
params=data if self.method == "GET" else None,
+ data=data if self.method in ("POST", "PUT", "PATCH") else
None,
Review Comment:
```suggestion
data=data,
```
do we really need that logic? shouldn't we do as the user asks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
