potiuk commented on code in PR #37293:
URL: https://github.com/apache/airflow/pull/37293#discussion_r1530498237
##########
airflow/providers/http/hooks/http.py:
##########
@@ -385,8 +387,9 @@ async def run(
for attempt in range(1, 1 + self.retry_limit):
response = await request_func(
url,
- json=data if self.method in ("POST", "PUT", "PATCH") else
None,
params=data if self.method == "GET" else None,
Review Comment:
I think that ship has sailed. The probability of breaking someone's many
hooks (including some of our providers that are using the Http Hook is far too
high (We have 5 hooks deriving from HttpHook in our repo). It would be heavily
breaking for users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
