lyuyunbo commented on code in PR #38008:
URL: https://github.com/apache/airflow/pull/38008#discussion_r1531011245
##########
airflow/providers/docker/operators/docker.py:
##########
@@ -420,6 +434,8 @@ def _run_image_with_mounts(self, target_mounts,
add_tmp_variable: bool) -> list[
)
logstream = self.cli.attach(container=self.container["Id"],
stdout=True, stderr=True, stream=True)
try:
+ self._change_log_formatters()
+
Review Comment:
That makes sense. Updated :)
However I think except would be more appropriate here, rather than finally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
