feluelle edited a comment on issue #5335: [AIRFLOW-4588] Add 
GoogleDiscoveryApiHook and GoogleApiToS3Transfer
URL: https://github.com/apache/airflow/pull/5335#issuecomment-526122327
 
 
   > However, I would suggest to incorporate proposed functionalities into 
already present GoogleCloudBaseHook to keep all gcp logic in one class.
   
   I wouldn't mix the implementations which are using Discovery API and gcp 
libraries. But I could imagine putting both into one module / file - not into a 
single class.
   
   (But I think I would prefer leaving it like it is, in separate modules.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to