feluelle edited a comment on issue #5335: [AIRFLOW-4588] Add 
GoogleDiscoveryApiHook and GoogleApiToS3Transfer
URL: https://github.com/apache/airflow/pull/5335#issuecomment-526725056
 
 
   @kaxil @nuclearpinguin @mik-laj @potiuk 
   
   What do you guys think of a deprecation warning if this hook is called with 
services where we already have a dedicated hook? So that users can then change 
to the dedicated hook if it has the functionality he needs.
   **OR**
   What if it dynamically changes to the dedicated hook's function if exists.
   So for example: 
   You call 
`GoogleDiscoveryApiHook.query(endpoint='bigtableadmin.projects.instances.get')` 
and it actually calls `BigtableHook.get_instance`. This would require a mapping 
between api endpoint and gcp hook function that we then probably need to 
manually update every time we add a new gcp (dedicated) hook.
   
   The second one is probably too _complex_.
   
   _and in the end we are about to mix the client-based and discovery based api 
- what we probably don't want. So..._

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to