vchiapaikeo commented on code in PR #38192:
URL: https://github.com/apache/airflow/pull/38192#discussion_r1534939714


##########
airflow/www/decorators.py:
##########
@@ -125,6 +126,9 @@ def wrapper(*args, **kwargs):
                     extra_fields = {**extra_fields, **masked_json}
 
                 params = {**request.values, **request.view_args}
+                
+                dag_id = params.get("dag_id") or 
session.scalar(select(DagRun.dag_id)
+                                                                
.where(DagRun.id == params.get("pk")))

Review Comment:
   What if we did something like this instead to avoid the issue mentioned 
earlier?
   ```suggestion
                   dag_id = params.get("dag_id") or 
(session.scalar(select(DagRun.dag_id)
                                                                   
.where(DagRun.id == params.get("pk"))) if event_name == "dagrun.delete" else 
None)
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to