Re: [PR] Fix in decorators to log dag-id during delete dag-run action #36057 [airflow]

Thu, 21 Mar 2024 20:14:51 -0700 


sachinp97 commented on PR #38192:
URL: https://github.com/apache/airflow/pull/38192#issuecomment-2014271206

   > > Do we use AirflowModelView.delete anywhere else? Or will pk always be a 
DagRun.id?
   > 
   > Yea, I think this is problematic because `AirflowModelView.delete` is used 
in several other places. For example, when I try to delete a TaskInstance, I am 
hit w/ this exception:
   > 
   > <img alt="image" width="1087" 
src="https://private-user-images.githubusercontent.com/9200263/315853372-1c9b9fda-11b4-4949-8746-1460ded85db9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTEwNzcyMzMsIm5iZiI6MTcxMTA3NjkzMywicGF0aCI6Ii85MjAwMjYzLzMxNTg1MzM3Mi0xYzliOWZkYS0xMWI0LTQ5NDktODc0Ni0xNDYwZGVkODVkYjkucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDMyMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAzMjJUMDMwODUzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZTY0NjZlOTRlMTUzMTEzNjViYzVhNDM5OWFhMzc4YjM3NjgzZWEwNTA1ODExYzMzNjk4ODQzNmFiOTFmNmJhYiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.4dHlyYe5wCc4yiawm7kRHbTLuG3-FS0_s30GJosahug";>
 <img alt="image" width="973" 
src="https://private-user-images.githubusercontent.com/9200263/315853452-18001ca4-4a41-4f3a-96f9-0438cf15f460.
 
png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTEwNzcyMzMsIm5iZiI6MTcxMTA3NjkzMywicGF0aCI6Ii85MjAwMjYzLzMxNTg1MzQ1Mi0xODAwMWNhNC00YTQxLTRmM2EtOTZmOS0wNDM4Y2YxNWY0NjAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDMyMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAzMjJUMDMwODUzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MTQ5YzU2NzBjOGZkOTI3NzVhN2YzZTJlOTBmZTBkMTg2ZTg4ODg0ZTg0ZGVmM2Q2NDQyNWZlMDNjYWFlOWQ2MCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.brxFjwbwqxUFkJRWN-ZtghyRz9ij_9mMOWIxVQs2OPk">
   
   Good catch @bbovenzi and Thanks @vchiapaikeo for suggested solution. 
   Although this works, it makes decorators bit clumsy with checks for specific 
use-cases. 
   What do you think? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to