enchant3dmango commented on code in PR #38413:
URL: https://github.com/apache/airflow/pull/38413#discussion_r1535967153
##########
dev/chart/build_changelog_annotations.py:
##########
@@ -98,7 +98,7 @@ def print_entry(section: str, description: str, pr_number:
int | None):
in_first_release = True
# Make sure we get past "significant features" before we actually
start keeping track
elif not past_significant_changes:
- if line == "New Features":
+ if line in TYPE_MAPPING:
Review Comment:
The TYPE_MAPPING has 5 key-value pairs in it.
So this change might have a different result from the previous code which
only checks if the line equals "New Features". Could you explain this change,
please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
