potiuk commented on code in PR #38413:
URL: https://github.com/apache/airflow/pull/38413#discussion_r1535975928
##########
dev/chart/build_changelog_annotations.py:
##########
@@ -98,7 +98,7 @@ def print_entry(section: str, description: str, pr_number:
int | None):
in_first_release = True
# Make sure we get past "significant features" before we actually
start keeping track
elif not past_significant_changes:
- if line == "New Features":
+ if line in TYPE_MAPPING:
Review Comment:
It's quite obvious - the code will fail if there are no New Features (like
in 1.13.1
##########
dev/chart/build_changelog_annotations.py:
##########
@@ -98,7 +98,7 @@ def print_entry(section: str, description: str, pr_number:
int | None):
in_first_release = True
# Make sure we get past "significant features" before we actually
start keeping track
elif not past_significant_changes:
- if line == "New Features":
+ if line in TYPE_MAPPING:
Review Comment:
It's quite obvious - the old code will fail if there are no New Features
(like in 1.13.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
