ephraimbuddy commented on PR #38094: URL: https://github.com/apache/airflow/pull/38094#issuecomment-2015670623
> Nice. The prefix is cool. > > There is one worry with that U just wanted to mention it. > > I understand that we are masking secreates before serialization ? Just wanted to amke sure sure of it - it looks like from the code , but I wanted to make sure we are not showing half-unmasked secrets accidentally when we truncate the secrets. The secrets are masked after serialization see: https://github.com/apache/airflow/blob/6a225ccb2a9b51c52df88368323993bcd017be0d/airflow/models/renderedtifields.py#L127. I have added a test and will also do manual testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
