ephraimbuddy commented on code in PR #38094: URL: https://github.com/apache/airflow/pull/38094#discussion_r1536707455
########## airflow/serialization/helpers.py: ########## @@ -38,7 +39,19 @@ def is_jsonable(x): else: return True + max_size = conf.getint("core", "max_templated_field_size") if not is_jsonable(template_field): - return str(template_field) + serialized = str(template_field) + if len(serialized) > max_size: + return ( + "Value removed due to size. " + "You can change this behaviour in [core]max_templated_field_size" + ) + return serialized else: + if template_field and len(str(template_field)) > max_size: + return ( + "Value removed due to size. " + "You can change this behaviour in [core]max_templated_field_size" + ) Review Comment: Changing to doing it in separate branches cause we can't use `if` statement on dataframe. It gives a valueerror -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org