ferruzzi commented on code in PR #38400:
URL: https://github.com/apache/airflow/pull/38400#discussion_r1538280611
##########
airflow/dag_processing/manager.py:
##########
@@ -1207,6 +1209,7 @@ def _kill_timed_out_processors(self):
processor.start_time.isoformat(),
)
Stats.decr("dag_processing.processes", tags={"file_path":
file_path, "action": "timeout"})
+ Stats.gauge("dag_processing.processes_count", -1, delta=True,
tags={"file_path": file_path, "action": "timeout"})
Stats.incr("dag_processing.processor_timeouts",
tags={"file_path": file_path})
Review Comment:
Not a bug as far as I am concerned. StatsD does not have the UpDownCounter
concept and their Gauges can be incremented/decremented. It's just an Otel vs
StatsD semantics issue. In your other comments below, you point out the issues
with making it a Gauage pretty well and more or less explain the reasons I did
it the way I did.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
