ferruzzi commented on code in PR #38400:
URL: https://github.com/apache/airflow/pull/38400#discussion_r1541520266
##########
airflow/dag_processing/manager.py:
##########
@@ -1207,6 +1209,7 @@ def _kill_timed_out_processors(self):
processor.start_time.isoformat(),
)
Stats.decr("dag_processing.processes", tags={"file_path":
file_path, "action": "timeout"})
+ Stats.gauge("dag_processing.processes_count", -1, delta=True,
tags={"file_path": file_path, "action": "timeout"})
Stats.incr("dag_processing.processor_timeouts",
tags={"file_path": file_path})
Review Comment:
It's not the most straight-forward thing, and the metric names are all so
similar, I totally get it. If you see a way to make it more clear, please
do! Documentation improvements and clarifications are often overlooked and at
least as important as code changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
