jedcunningham commented on code in PR #38506:
URL: https://github.com/apache/airflow/pull/38506#discussion_r1540366990
##########
airflow/www/views.py:
##########
@@ -2782,6 +2782,9 @@ def grid(self, dag_id: str, session: Session =
NEW_SESSION):
wwwutils.check_import_errors(dag.fileloc, session)
wwwutils.check_dag_warnings(dag.dag_id, session)
+ included_events_raw = conf.get("webserver",
"audit_view_included_events", fallback="")
+ excluded_events_raw = conf.get("webserver",
"audit_view_excluded_events", fallback="")
Review Comment:
I'm a little confused, maybe you can explain it to me.
Deployment managers set these 2 to control what is shown in this UI view.
I'm not sure we want to allow bypassing these configuration values, even if
audit log access requires a high level of permissions.
Does this new feature honor this and just allow filtering based on the list
of events the user would already see, or does it allow the user to make
different choices than what the deployment manager configured?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
