Re: [PR] Add exclude/include events filters to audit log [airflow]

Tue, 02 Apr 2024 01:48:48 -0700 


phanikumv commented on PR #38506:
URL: https://github.com/apache/airflow/pull/38506#issuecomment-2031425887

   > Found a few issues while giving this a spin.
   > 
   > "No options" - when you first enter into the filter form field, it says 
there are no options. Even when you start typing say "ru", "running" doesn't 
come up. Is it possible to hide the suggested options entirely? If you do want 
suggestions to work, it really needs to be a complete list of events for the 
DAG (which likely isn't trivial to get with the current rest api).
   > 
   > <img alt="Screenshot 2024-03-29 at 1 47 43 PM" width="342" 
src="https://private-user-images.githubusercontent.com/66968678/318108902-e61e7081-8055-4783-ad03-d6aa44f5c925.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTIwNDc4MzksIm5iZiI6MTcxMjA0NzUzOSwicGF0aCI6Ii82Njk2ODY3OC8zMTgxMDg5MDItZTYxZTcwODEtODA1NS00NzgzLWFkMDMtZDZhYTQ0ZjVjOTI1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA0MDIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNDAyVDA4NDUzOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWMzMWVhMjkzZjljODg3YjlhYTg2OWFmNDI1YWQ4NmQzMTM3ZmZmNjBlYzRlNTRjOTZmN2Y3ZjVhNmEzMGNlMDkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.cFIZsV0RqmJPl_tUEhv-ZZxGaB8Ev8B9XlNI012QUPY";>
   > Both included and excluded events - can we maybe disable the "excluded" 
events form field when the "included" events is populated? Having both on is a 
little funky and it feels natural for "included" to take higher precedence to 
me.
   > 
   > Not really related to this change, but I noticed the count isn't using the 
included/excluded event filter. See #38625.
   
   Let's resolve these findings in a follow-up PR. Merging this so that we can 
include in 2.9.0
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to