dabla opened a new pull request, #38715:
URL: https://github.com/apache/airflow/pull/38715
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: [#37246](https://github.com/apache/airflow/pull/37246)
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
In my [previous pull request](https://github.com/apache/airflow/pull/37246)
I added the executemany parameter to allow you to choose which strategy to
apply when inserting rows as the executemany method is way much faster than the
original implementation (see picture when we did the performance comparison
with thousands of records inserted in bulk). With the original implemention we
had to cancel the task as it did take up too much time while with executemany
strategy it completed it merely a few minutes. So I decided to create this new
pull request and always apply the faster executemany strategy, as the operator
using the hook didn't have any way to change that property anyway and there was
anythin foreseen to configure that parameter in the connection too. Also why
keep both strategies if one is better than the other, then it's better to ditch
the slower one which makes the code less complex and easier to read.
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
