dabla commented on PR #38715: URL: https://github.com/apache/airflow/pull/38715#issuecomment-2041997794
> Would love other reviews, but it looks good. > > NIT: why changing types in tests to string? Will that work for all common.sql users? also NIT2 - we should let users know y depreaction warning if they are still using executemany as parameter. I changed the values to string as each cell is being serialized by the _serialize_cell method before being inserted, which makes it easier to assert. That was also the case with the original implementation, we can keep the ints but then we will have to adapt the expected values to strings due to the call to the _serialize_cell method for each value in the row. I will add a deprecating warning for the executemany parameter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
