squingo44 opened a new pull request, #38726:
URL: https://github.com/apache/airflow/pull/38726
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
During the heartbeat check, the `local_task_job_runner` performs a check on
the job's PID and raises an exception if it doesn't match what it expects.
In the case that the job is a child process (ie. when running as another
user), this check will instead occur on the job's parent PID.
The condition for triggering this alternate route is `run_as_user` having a
non-None value. This condition is correct, except for the case where
`run_as_user` has been set to user as which Airflow is already running, in
which case [`run_as_user` is ignored when the TaskRunner is
initialialized](https://github.com/apache/airflow/blob/main/airflow/task/task_runner/base_task_runner.py#L74).
This means that whenever an Airflow user sets `run_as_user` to the user as
which they're already running Airflow, [they would get an
error](https://github.com/apache/airflow/discussions/38128#discussioncomment-8806266),
and be told to unset the `run_as_user` attribute. However, there is a
legitimate use case for this: `run_as_user` can be used to override
`default_impersonation` back to the `airflow_uid` user.
This change updates the "is_child_process" condition within the exception
handler to reflect this use case. It makes this use case succeed silently
instead of throwing an error.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
