Lee-W commented on PR #38674: URL: https://github.com/apache/airflow/pull/38674#issuecomment-2042328464
> I wonder if we could somehow infer `starts_execution_from_triggerer` from the combination of other arguments, instead of setting the flag explicitly. For this specific case, I would say yes. We could check whether `start_trigger` is None to decide. Not sure whether we would want to use this chance to refactor all the existing operators with deferrable support. (e.g., Moving the trigger definition to `__init__` or somewhere else maybe?) Also, the name is set to `start_trigger` instead `trigger` because https://airflow.apache.org/docs/apache-airflow-providers-google/stable/operators/cloud/cloud_build.html already take this argument name. Without changing this name to something else, mypy and many tests complain. `start_trigger` is more like a temporary name. Suggestions are welcomed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
