uranusjr commented on code in PR #38674:
URL: https://github.com/apache/airflow/pull/38674#discussion_r1571831512


##########
airflow/models/baseoperator.py:
##########
@@ -1072,6 +1072,8 @@ def __init__(
         if SetupTeardownContext.active:
             SetupTeardownContext.update_context_map(self)
 
+        self._start_trigger: BaseTrigger | None = getattr(self, 
"_start_trigger", None)

Review Comment:
   This patterns seems weird. Why do we try to get an attribue on self and 
assign the result back to self in `__init__`? When can the attribute be set 
before this point?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to