rawwar commented on PR #38831: URL: https://github.com/apache/airflow/pull/38831#issuecomment-2043040070
@Taragolis , based on your comment [here](https://github.com/apache/airflow/issues/38195#issuecomment-2042644747) > As far as i remember, we recently discuss this case in slack. I guess better introduce sa_uri property (or some similar naming) which returns [sqlalchemy.engine.URL](https://docs.sqlalchemy.org/en/14/core/engines.html#sqlalchemy.engine.URL) into the DbApiHook without any implementation, e.g. raise NotImplementedError and implements it per hook which have implementation for SQAlchemy. I guess we leave the implementation of `get_uri` dependent on the provider type. If so, do we really need to have `sa_uri` property with `NotImplementedError`? Since SqlAlchemy URI is pre-defined, we can consider using the connection and try to form the URI. Raise an error if it has issues. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
