rawwar commented on PR #38831:
URL: https://github.com/apache/airflow/pull/38831#issuecomment-2045402639
> I would rather do not mix-in introduce changes into DBApiHook and other
hook in the same PR unless absolutely necessary. So I would rather create a new
propery (via separate PR), describe where it could be used right now and where
it could be used in the future.
I understand. I will first make the updates to the `DBApiHook` and then go
ahead with the individual provider updates.
> If we talk about this PR, it is not clear what at this moment it fix, new
property it is fine, but there is no any description about this property and
how to use it.
I understand. Thanks for the feedback. What I intended to do is as you
described
[here](https://github.com/apache/airflow/issues/38195#issuecomment-2042644747)
. To have a property `sa_uri` in the `DBApiHook` which doesn't have any
implementation. But, rather a placeholder property that should be implemented
in the providers that use SqlAlchemy URI. This property returns the
`sqlalchemy.engine.URL` object which can be used by the `get_uri` to form a
SqlAlchemy-based URI. Hope I am making sense.
For now, I will separate out the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
