dstandish commented on code in PR #38943:
URL: https://github.com/apache/airflow/pull/38943#discussion_r1562046802


##########
airflow/models/taskinstance.py:
##########
@@ -539,7 +539,7 @@ def _refresh_from_db(
         task_instance.end_date = ti.end_date
         task_instance.duration = ti.duration
         task_instance.state = ti.state
-        task_instance.try_number = ti._try_number  # private attr to get value 
unaltered by accessor
+        task_instance.try_number = _get_private_try_number(task_instance=ti)

Review Comment:
   Yes this problem should go away completely 
   
   I actually doubt we really need these shenanigans now (specifically the 
conditional +1 logic)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to