potiuk commented on code in PR #38943:
URL: https://github.com/apache/airflow/pull/38943#discussion_r1562477057
##########
airflow/models/taskinstance.py:
##########
@@ -539,7 +539,7 @@ def _refresh_from_db(
task_instance.end_date = ti.end_date
task_instance.duration = ti.duration
task_instance.state = ti.state
- task_instance.try_number = ti._try_number # private attr to get value
unaltered by accessor
+ task_instance.try_number = _get_private_try_number(task_instance=ti)
Review Comment:
I think there were at least one or two attempts I remember in the past to
remove it - and failed so far.
I believe there is race conditions that try number is increased in the DB
when task state is changed from RUNNING to FAILED (for example when user stops
the task from the UI) and try_number is already stored in the DB - but the
running task might still be running and stopping itself, so it should continue
logging to the same try_number it was started with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
