o-nikolas commented on code in PR #38967:
URL: https://github.com/apache/airflow/pull/38967#discussion_r1562955354
##########
tests/system/conftest.py:
##########
@@ -51,7 +51,14 @@ def pytest_collection_modifyitems(config: pytest.Config,
items: list[pytest.Item
rootdir = config.rootpath
for item in items:
rel_path = item.path.relative_to(rootdir)
+
+ # Provider system tests
match = re.match(".+/system/providers/([^/]+)", str(rel_path))
if match:
provider = match.group(1)
item.add_marker(pytest.mark.system(provider))
+
+ # Core system tests
+ match = re.match(".+/system/[^/]+", str(rel_path))
+ if match:
+ item.add_marker(pytest.mark.system("core"))
Review Comment:
Why do we need this? Couldn't we just put the system test in the `common`
provider and it would be picked up as normal? Or are we worried that actual
system tests would eventually live there and get accidentally run by the
Airlfow CI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
