vincbeck commented on code in PR #38967:
URL: https://github.com/apache/airflow/pull/38967#discussion_r1562964822
##########
tests/system/conftest.py:
##########
@@ -51,7 +51,14 @@ def pytest_collection_modifyitems(config: pytest.Config,
items: list[pytest.Item
rootdir = config.rootpath
for item in items:
rel_path = item.path.relative_to(rootdir)
+
+ # Provider system tests
match = re.match(".+/system/providers/([^/]+)", str(rel_path))
if match:
provider = match.group(1)
item.add_marker(pytest.mark.system(provider))
+
+ # Core system tests
+ match = re.match(".+/system/[^/]+", str(rel_path))
+ if match:
+ item.add_marker(pytest.mark.system("core"))
Review Comment:
As far as I understand, `common` is not a provider in itself. `common-io`
and `common-sql` are. So putting the system test in either of the two does not
really makes sense to me. That's why I preferred putting it in core Airflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
