vincbeck commented on code in PR #38972:
URL: https://github.com/apache/airflow/pull/38972#discussion_r1563046987
##########
airflow/providers/common/sql/hooks/sql.py:
##########
@@ -594,7 +594,7 @@ def insert_rows(
conn.commit()
self.log.info("Loaded %s rows into %s so far", i,
table)
conn.commit()
- self.log.info("Done loading. Loaded a total of %s rows into %s",
len(rows), table)
+ self.log.info("Done loading. Loaded a total of %s rows into %s",
len(list(rows)), table)
Review Comment:
Should I create an old school increment in the two for loop or is there any
better/pythonic way?
##########
airflow/providers/common/sql/hooks/sql.py:
##########
@@ -594,7 +594,7 @@ def insert_rows(
conn.commit()
self.log.info("Loaded %s rows into %s so far", i,
table)
conn.commit()
- self.log.info("Done loading. Loaded a total of %s rows into %s",
len(rows), table)
+ self.log.info("Done loading. Loaded a total of %s rows into %s",
len(list(rows)), table)
Review Comment:
Should I create an old school increment in the two for loops or is there any
better/pythonic way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
