dabla commented on code in PR #38972:
URL: https://github.com/apache/airflow/pull/38972#discussion_r1563139049
##########
airflow/providers/common/sql/hooks/sql.py:
##########
@@ -594,7 +594,7 @@ def insert_rows(
conn.commit()
self.log.info("Loaded %s rows into %s so far", i,
table)
conn.commit()
- self.log.info("Done loading. Loaded a total of %s rows into %s",
len(rows), table)
+ self.log.info("Done loading. Loaded a total of %s rows into %s",
len(list(rows)), table)
Review Comment:
Sorry my bad indeed I didn’t know why they used an old school counter. Maybe
add a unit test then to make sure that case is also covered?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
