romsharon98 commented on code in PR #38892:
URL: https://github.com/apache/airflow/pull/38892#discussion_r1566141583
##########
airflow/models/taskinstance.py:
##########
@@ -1213,10 +1213,11 @@ def _run_finished_callback(
if callbacks:
callbacks = callbacks if isinstance(callbacks, list) else [callbacks]
for callback in callbacks:
+ callback_name = qualname(callback).split(".")[-1]
try:
+ log.info("Executing %s callback", callback_name)
Review Comment:
> Also since we only use the last component, we can just use
`callback.__name__` for the same effect (or just `callback`). I know this is
inherited from existing code.
when changing to `callback.__name__` works.
just to let you know, changing to `callback` didn't work:
<img width="689" alt="image"
src="https://github.com/apache/airflow/assets/33751805/e3638098-2015-434b-b7a4-8ad61c0af005";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
