Taragolis commented on code in PR #38892:
URL: https://github.com/apache/airflow/pull/38892#discussion_r1559467638
##########
tests/models/test_taskinstance.py:
##########
@@ -2856,8 +2856,9 @@ def on_execute_callable(context):
],
)
@patch("logging.Logger.exception")
+ @patch("logging.Logger.info")
Review Comment:
And in general this test case have some drawbacks.
E.g. `called` set only in the beginning to False, after that callback
executed twice in the loop.
So assign `called = completed = False` also should be call into the
beginning of the loop,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
