e-galan commented on code in PR #38716:
URL: https://github.com/apache/airflow/pull/38716#discussion_r1566949795
##########
tests/providers/apache/beam/operators/test_beam.py:
##########
@@ -256,6 +256,59 @@ def test_on_kill_direct_runner(self, _, dataflow_mock, __):
op.on_kill()
dataflow_cancel_job.assert_not_called()
+ @mock.patch(BEAM_OPERATOR_PATH.format("BeamHook"))
+ @mock.patch(BEAM_OPERATOR_PATH.format("GCSHook"))
+ def test_execute_gcs_hook_called_only_with_gs_prefix(self, mock_gcs_hook,
_):
Review Comment:
@zstrathe In my opinion it is better to break this up into 3 separate tests.
Otherwise the code looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
