Re: [PR] Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator [airflow]

[via GitHub]

zstrathe commented on code in PR #38716:
URL: https://github.com/apache/airflow/pull/38716#discussion_r1568197801


##########
tests/providers/apache/beam/operators/test_beam.py:
##########
@@ -256,6 +256,59 @@ def test_on_kill_direct_runner(self, _, dataflow_mock, __):
         op.on_kill()
         dataflow_cancel_job.assert_not_called()
 
+    @mock.patch(BEAM_OPERATOR_PATH.format("BeamHook"))
+    @mock.patch(BEAM_OPERATOR_PATH.format("GCSHook"))
+    def test_execute_gcs_hook_called_only_with_gs_prefix(self, mock_gcs_hook, 
_):

Review Comment:
   @e-galan Thanks, that's now updated:
   
   
![image](https://github.com/apache/airflow/assets/59071005/abd7d7aa-5574-4dc2-bae7-12c7f9c8aedb)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org