potiuk commented on code in PR #39055:
URL: https://github.com/apache/airflow/pull/39055#discussion_r1566990719
##########
airflow/api_connexion/endpoints/connection_endpoint.py:
##########
@@ -91,7 +91,7 @@ def get_connection(*, connection_id: str, session: Session =
NEW_SESSION) -> API
@provide_session
def get_connections(
*,
- limit: int,
+ limit: int | None = None,
Review Comment:
@RobbeSneyders -> we found that the new Connexion 3 implements more
validation and responds with error where no default values are provided for
parameters that are no defined as optional (but they are provided by decorators
- see above `@format_parameters` decorator - it will set the default value of
the parameter if not set - but Connexion 3 will respond with "bad request" if
the parameter has no default value. We fixed it by adding default None and
reworking the decorator to check it and replace the default value (and apply
range limits) if None is set, but I just wanted you to know and ask if that is
intended behaviour/right way of fixing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
