potiuk commented on code in PR #39055:
URL: https://github.com/apache/airflow/pull/39055#discussion_r1567020644
##########
airflow/cli/commands/internal_api_command.py:
##########
@@ -198,7 +198,8 @@ def start_and_monitor_gunicorn(args):
def create_app(config=None, testing=False):
"""Create a new instance of Airflow Internal API app."""
- flask_app = Flask(__name__)
+ connexion_app = connexion.FlaskApp(__name__)
Review Comment:
@RobbeSneyders - where we are doing what you recommended originally - so
we are using connexion's FlaskApp to wrap and create Flask Application that
Connexion will use - and then we are using that Flask application down the
line to register our specific application endpoints, error handling and some
"Flask" middleware (we still have not connected all our extensions to ASGI
middleware because we wanted to minimise the changes needed. Does it sound
about right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
