jscheffl commented on code in PR #39055:
URL: https://github.com/apache/airflow/pull/39055#discussion_r1567870137
##########
airflow/www/package.json:
##########
@@ -141,7 +141,8 @@
"reactflow": "^11.7.4",
"redoc": "^2.0.0-rc.72",
"remark-gfm": "^3.0.1",
- "swagger-ui-dist": "4.1.3",
+ "sanitize-html": "^2.12.1",
Review Comment:
Are you sure this dependency is needed? It was just removed when adding
color logs. Or is this a merge-mistake? Can not see it used in JS code... (or I
have tomatoes on my eyes?)
##########
airflow/api_connexion/endpoints/connection_endpoint.py:
##########
@@ -91,7 +91,7 @@ def get_connection(*, connection_id: str, session: Session =
NEW_SESSION) -> API
@provide_session
def get_connections(
*,
- limit: int,
+ limit: int | None = None,
Review Comment:
If you want to reduce the complexity of this PR, could such simple bulk
changes separated-out to s different PR and merged beforehand? Or would this
influence/break the old Connexion setup?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
