potiuk commented on code in PR #39055:
URL: https://github.com/apache/airflow/pull/39055#discussion_r1570542326
##########
airflow/api_connexion/endpoints/connection_endpoint.py:
##########
@@ -91,7 +91,7 @@ def get_connection(*, connection_id: str, session: Session =
NEW_SESSION) -> API
@provide_session
def get_connections(
*,
- limit: int,
+ limit: int | None = None,
Review Comment:
@RobbeSneyders: yes:
Example stack trace here (from
https://github.com/apache/airflow/actions/runs/8581603105/job/23518857077 for
example).
```
ERROR connexion.middleware.exceptions:exceptions.py:97
TypeError("get_dataset_events() missing 1 required keyword-only argument:
'limit'")
Traceback (most recent call last):
File
"/usr/local/lib/python3.8/site-packages/starlette/_exception_handler.py", line
53, in wrapped_app
await app(scope, receive, sender)
File
"/usr/local/lib/python3.8/site-packages/connexion/middleware/swagger_ui.py",
line 222, in __call__
await self.router(scope, receive, send)
File "/usr/local/lib/python3.8/site-packages/starlette/routing.py", line
756, in __call__
await self.middleware_stack(scope, receive, send)
File "/usr/local/lib/python3.8/site-packages/starlette/routing.py", line
776, in app
await route.handle(scope, receive, send)
File "/usr/local/lib/python3.8/site-packages/starlette/routing.py", line
485, in handle
await self.app(scope, receive, send)
File "/usr/local/lib/python3.8/site-packages/starlette/routing.py", line
756, in __call__
await self.middleware_stack(scope, receive, send)
File "/usr/local/lib/python3.8/site-packages/starlette/routing.py", line
806, in app
await self.default(scope, receive, send)
File
"/usr/local/lib/python3.8/site-packages/connexion/middleware/swagger_ui.py",
line 235, in default_fn
await self.app(original_scope, receive, send)
File
"/usr/local/lib/python3.8/site-packages/starlette/middleware/cors.py", line 85,
in __call__
await self.app(scope, receive, send)
File
"/usr/local/lib/python3.8/site-packages/starlette/middleware/cors.py", line 85,
in __call__
await self.app(scope, receive, send)
File
"/usr/local/lib/python3.8/site-packages/connexion/middleware/routing.py", line
154, in __call__
await self.router(scope, receive, send)
File "/usr/local/lib/python3.8/site-packages/starlette/routing.py", line
756, in __call__
await self.middleware_stack(scope, receive, send)
File "/usr/local/lib/python3.8/site-packages/starlette/routing.py", line
776, in app
await route.handle(scope, receive, send)
File "/usr/local/lib/python3.8/site-packages/starlette/routing.py", line
485, in handle
await self.app(scope, receive, send)
File "/usr/local/lib/python3.8/site-packages/starlette/routing.py", line
756, in __call__
await self.middleware_stack(scope, receive, send)
File "/usr/local/lib/python3.8/site-packages/starlette/routing.py", line
776, in app
await route.handle(scope, receive, send)
File "/usr/local/lib/python3.8/site-packages/starlette/routing.py", line
297, in handle
await self.app(scope, receive, send)
File
"/usr/local/lib/python3.8/site-packages/connexion/middleware/routing.py", line
48, in __call__
await self.next_app(original_scope, receive, send)
File
"/usr/local/lib/python3.8/site-packages/connexion/middleware/abstract.py", line
264, in __call__
return await operation(scope, receive, send)
File
"/usr/local/lib/python3.8/site-packages/connexion/middleware/security.py", line
106, in __call__
await self.next_app(scope, receive, send)
File
"/usr/local/lib/python3.8/site-packages/connexion/middleware/abstract.py", line
264, in __call__
return await operation(scope, receive, send)
File
"/usr/local/lib/python3.8/site-packages/connexion/middleware/request_validation.py",
line 142, in __call__
await self.next_app(scope, receive, send)
File
"/usr/local/lib/python3.8/site-packages/connexion/middleware/abstract.py", line
264, in __call__
return await operation(scope, receive, send)
File
"/usr/local/lib/python3.8/site-packages/connexion/middleware/lifespan.py", line
26, in __call__
await self.next_app(scope, receive, send)
File
"/usr/local/lib/python3.8/site-packages/connexion/middleware/abstract.py", line
264, in __call__
return await operation(scope, receive, send)
File
"/usr/local/lib/python3.8/site-packages/connexion/middleware/context.py", line
25, in __call__
await self.next_app(scope, receive, send)
File "/usr/local/lib/python3.8/site-packages/connexion/apps/flask.py",
line 151, in __call__
return await self.asgi_app(scope, receive, send)
File "/usr/local/lib/python3.8/site-packages/a2wsgi/wsgi.py", line 165,
in __call__
return await responder(scope, receive, send)
File "/usr/local/lib/python3.8/site-packages/a2wsgi/wsgi.py", line 200,
in __call__
await self.loop.run_in_executor(
File "/usr/local/lib/python3.8/concurrent/futures/thread.py", line 57,
in run
result = self.fn(*self.args, **self.kwargs)
File "/usr/local/lib/python3.8/site-packages/a2wsgi/wsgi.py", line 256,
in wsgi
iterable = self.app(environ, start_response)
File "/usr/local/lib/python3.8/site-packages/flask/app.py", line 2532,
in wsgi_app
response = self.handle_exception(e)
File "/usr/local/lib/python3.8/site-packages/flask/app.py", line 2529,
in wsgi_app
response = self.full_dispatch_request()
File "/usr/local/lib/python3.8/site-packages/flask/app.py", line 1825,
in full_dispatch_request
rv = self.handle_user_exception(e)
File "/usr/local/lib/python3.8/site-packages/flask/app.py", line 1823,
in full_dispatch_request
rv = self.dispatch_request()
File "/usr/local/lib/python3.8/site-packages/flask/app.py", line 1799,
in dispatch_request
return
self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)
File "/usr/local/lib/python3.8/site-packages/connexion/apps/flask.py",
line 68, in __call__
return self.fn(*args, **kwargs)
File
"/usr/local/lib/python3.8/site-packages/connexion/decorators/main.py", line
134, in wrapper
return decorated_function(request)
File
"/usr/local/lib/python3.8/site-packages/connexion/decorators/response.py", line
171, in wrapper
handler_response = function(*args, **kwargs)
File
"/usr/local/lib/python3.8/site-packages/connexion/decorators/parameter.py",
line 87, in wrapper
return function(**kwargs)
File
"/usr/local/lib/python3.8/site-packages/connexion/decorators/main.py", line
123, in wrapper
return function(*args, **kwargs)
File "/opt/airflow/airflow/api_connexion/security.py", line 182, in
decorated
return _requires_access(
File "/opt/airflow/airflow/api_connexion/security.py", line 92, in
_requires_access
return func(*args, **kwargs)
File "/opt/airflow/airflow/utils/session.py", line 79, in wrapper
return func(*args, session=session, **kwargs)
File "/opt/airflow/airflow/api_connexion/parameters.py", line 104, in
wrapped_function
return func(*args, **kwargs)
TypeError: get_dataset_events() missing 1 required keyword-only argument:
'limit'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
