potiuk commented on code in PR #39055:
URL: https://github.com/apache/airflow/pull/39055#discussion_r1570549535
##########
airflow/www/app.py:
##########
@@ -49,19 +50,20 @@
)
from airflow.www.extensions.init_session import init_airflow_session_interface
from airflow.www.extensions.init_views import (
- init_api_auth_provider,
+ init_api_auth_manager,
init_api_connexion,
init_api_error_handlers,
init_api_experimental,
init_api_internal,
init_appbuilder_views,
+ init_cors_middleware,
init_error_handlers,
init_flash_views,
init_plugins,
)
from airflow.www.extensions.init_wsgi_middlewares import init_wsgi_middleware
-app: Flask | None = None
+app: connexion.FlaskApp | None = None
Review Comment:
Yes. Good point, If we go that direction, likely we might want to move
Connexion FlaskApp to `connexion_app` or similar field, and leave the `app` one
as `Flask` app. Having two `app` is grossly misleading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
