uranusjr commented on code in PR #39094:
URL: https://github.com/apache/airflow/pull/39094#discussion_r1571822427


##########
airflow/models/dagrun.py:
##########
@@ -614,6 +620,7 @@ def _check_last_n_dagruns_failed(self, dag_id, 
max_consecutive_failed_dag_runs,
     def get_task_instances(
         self,
         state: Iterable[TaskInstanceState | None] | None = None,
+        dag_run_option: Literal["lazy", "joined"] = "joined",

Review Comment:
   Maybe something like `load_run_option` instead? This sounds like an option 
to DAG run instead of db-loading.
   
   I kind of feel we should just avoid trying to abstract this sort of things 
in the first place too. Using SQL (or ORM) calls directly is more often the 
correct abstraction.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to