dstandish commented on code in PR #39094:
URL: https://github.com/apache/airflow/pull/39094#discussion_r1573306722
##########
airflow/models/dagrun.py:
##########
@@ -614,6 +620,7 @@ def _check_last_n_dagruns_failed(self, dag_id,
max_consecutive_failed_dag_runs,
def get_task_instances(
self,
state: Iterable[TaskInstanceState | None] | None = None,
+ dag_run_option: Literal["lazy", "joined"] = "joined",
Review Comment:
so would you say, @uranusjr , in this case, we should just inline the
querying for this use case? E.g. duplicate [only the needed bits of] this to
the DepContext class?
one complicating factor is that this ultimately needs to be rpc-compatible.
so it needs to be enclosed in a function somehow. but, it doesn't have to be
a function shared by anything else. so it could be
`DepContext._get_finished_tis` for example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
