ferruzzi commented on code in PR #39151:
URL: https://github.com/apache/airflow/pull/39151#discussion_r1575017105
##########
airflow/providers/amazon/aws/operators/s3.py:
##########
@@ -503,23 +509,37 @@ def __init__(
self.bucket = bucket
self.keys = keys
self.prefix = prefix
+ self.from_datetime = from_datetime
+ self.to_datetime = to_datetime
self.aws_conn_id = aws_conn_id
self.verify = verify
self._keys: str | list[str] = ""
- if not exactly_one(prefix is None, keys is None):
- raise AirflowException("Either keys or prefix should be set.")
+ if not exactly_one(keys is None, all([prefix is None, from_datetime is
None, to_datetime is None])):
+ raise AirflowException(
+ "Either keys or at least one of prefix, from_datetime,
to_datetime should be set."
Review Comment:
That message does not match what the code is enforcing. The code says
either keys or all of the others, no? Isn't this saying either keys can be
empty or all the rest are? Maybe I'm just getting confused by the double
negative here.
What is you change it to a positive check like:
```suggestion
if not exactly_one(keys, at_least_one(prefix, from_datetime,
to_datetime])):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
