ferruzzi commented on code in PR #39151:
URL: https://github.com/apache/airflow/pull/39151#discussion_r1575019834
##########
airflow/providers/amazon/aws/operators/s3.py:
##########
@@ -503,23 +509,37 @@ def __init__(
self.bucket = bucket
self.keys = keys
self.prefix = prefix
+ self.from_datetime = from_datetime
+ self.to_datetime = to_datetime
self.aws_conn_id = aws_conn_id
self.verify = verify
self._keys: str | list[str] = ""
- if not exactly_one(prefix is None, keys is None):
- raise AirflowException("Either keys or prefix should be set.")
+ if not exactly_one(keys is None, all([prefix is None, from_datetime is
None, to_datetime is None])):
+ raise AirflowException(
+ "Either keys or at least one of prefix, from_datetime,
to_datetime should be set."
Review Comment:
I was playing with that in ipython and looking at the unit tests, and
apparently an empty list and an empty string are considered valid values?
That feels wrong to me. If one must be provided, then surely providing an
empty value shouldn't count? That complicates things and I guess explains why
this statement is convoluted.
My initial statement stands though, I'm pretty sure this is not testing what
your error message says it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
