Lee-W commented on code in PR #39018:
URL: https://github.com/apache/airflow/pull/39018#discussion_r1576315441
##########
airflow/providers/google/cloud/hooks/dataflow.py:
##########
@@ -736,6 +736,69 @@ def start_template_dataflow(
jobs_controller.wait_for_done()
return response["job"]
+ @_fallback_to_location_from_variables
+ @_fallback_to_project_id_from_variables
+ @GoogleBaseHook.fallback_to_default_project_id
+ def launch_job_with_template(
Review Comment:
Looks like this function could be part of `start_template_dataflow`. Should
we introduce a flag to `start_template_dataflow` to decide whether we want to
wait?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
