e-galan commented on code in PR #39018:
URL: https://github.com/apache/airflow/pull/39018#discussion_r1580752703
##########
tests/providers/google/cloud/operators/test_dataflow.py:
##########
@@ -540,8 +559,9 @@ def test_validation_deferrable_params_raises_error(self):
DataflowTemplatedJobStartOperator(**init_kwargs)
@pytest.mark.db_test
-
@mock.patch("airflow.providers.google.cloud.operators.dataflow.DataflowHook.start_template_dataflow")
- def test_start_with_custom_region(self, dataflow_mock):
+ @mock.patch(f"{DATAFLOW_PATH}.DataflowTemplatedJobStartOperator.xcom_push")
+ @mock.patch(f"{DATAFLOW_PATH}.DataflowHook.start_template_dataflow")
+ def test_start_with_custom_region(self, dataflow_mock, mock_xcom_push):
Review Comment:
I did not think that we should assert if every mock was called or not, and
added it just to make the test pass. Since we're not testing xcom_push anywhere
else, I think I could add the call assert. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
